Add descriptive message for protocol timeout #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajkumar S <rajkumaar2304@icloud.com>
|
@lirantal Let me know if you could think of a better descriptive message for the timeout. |
|
Looks good to me, thanks Raj! ❤️ |
|
🎉 This PR is included in version 1.14.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to handle the error with a code of PROTOCOL_TIMEOUT with a descriptive error message.
Types of changes
Related Issue
Fixes #73
Motivation and Context
When there's a PROTOCOL_TIMEOUT error, we need to detect and gracefully handle with a descriptive error message.
How Has This Been Tested?
Used the command to run against a website that is blocked by my ISP and received this descriptive error message.
Screenshots (if appropriate):
Checklist: