Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contained elements are never fully adopted and always match :unresolved #407

Closed
depeele opened this issue Jul 21, 2018 · 1 comment
Closed

Comments

@depeele
Copy link

depeele commented Jul 21, 2018

Commit 8697b40 which was used to close issue #231 causes issues with contained custom elements.

Contained custom elements are never fully adopted even when the containing element is finally adopted. This means that contained elements will always be matched by the :unresolved CSS pseudo-property.

In https://codepen.io/depeele/pen/QBdZyo using lit-html:v0.10.0 the contained test-item is considered resolved in the final document.

In https://codepen.io/depeele/pen/PBWyzB using lit-html:v0.10.1 but otherwise the same code, test-item is not considered resolved in the final document.

@depeele
Copy link
Author

depeele commented Jul 26, 2018

Turns out, the WebComponents standards committee decided to rename :unresolved to :not(:defined) (w3c/webcomponents issue 418).

See https://codepen.io/depeele/pen/gjGPRy which uses lit-html:v0.10.1 and the new pseudo-property.

@depeele depeele closed this as completed Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant