Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate upload API error #51

Open
2 tasks
NicolasMahe opened this issue Oct 17, 2022 · 0 comments
Open
2 tasks

Translate upload API error #51

NicolasMahe opened this issue Oct 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Oct 17, 2022

Original Trello card: https://trello.com/c/9GnFunrD/151-unlockable-content-translate-upload-api-error

Need to translate error returned by API

Currently only 2 errors can be easily translated as they are "key" based rather than sentence based.

Related to last step of https://trello.com/c/0YQMZLV4/125-onlyshoot-unlockable-content-ux-improvements-to-prevent-the-creation-of-nfts-that-have-already-being-minted-as-unlockable-conten

  • Need to find a proper way to translate those error. If I take file_is_already_public and file_is_already_private errors, they are inside another error with a different message. Should we create a new error class that have the translation key explicitly defined?

  • Note on errors file_is_already_public and file_is_already_private:
    Need some discussion about how to do it properly. The best is for the error to be showed directly in the form in the right dropzone.

Once this issue is done, we should expand this system to all API error. Need to create a new card for this point

  • file_is_already_public
  • file_is_already_private
@NicolasMahe NicolasMahe added the enhancement New feature or request label Oct 17, 2022
@antho1404 antho1404 transferred this issue from another repository Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant