Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten deps #55

Closed
NicolasMahe opened this issue Oct 21, 2022 · 3 comments · Fixed by #66
Closed

Flatten deps #55

NicolasMahe opened this issue Oct 21, 2022 · 3 comments · Fixed by #66

Comments

@NicolasMahe
Copy link
Member

We currently have Chakra installed multiple time:

apps/admin/node_modules/@chakra-ui/react
apps/test/node_modules/@chakra-ui/react
packages/components/node_modules/@chakra-ui/react
packages/templates/node_modules/@chakra-ui/react

We should have only have one installation of chakra, any major libs actually, and make sure in the future that deps are flatten to avoid having different versions.

This is the source of issue #21.

I created a draft PR to test and it's working well:
https://github.com/liteflow-labs/nft/pull/1988
Need to redo the PR properly without removing all the extra deps to make it work.

@achampagnedev
Copy link
Contributor

achampagnedev commented Oct 24, 2022

@NicolasMahe Do you think these 2 could be related? https://github.com/liteflow-labs/nft/pull/2219. It works fine in @nft/components but have issue to build in @nft/templates There's a ChakraUI in each package.

@NicolasMahe
Copy link
Member Author

@NicolasMahe Do you think these 2 could be related? liteflow-labs/nft#2219. It works fine in @nft/components but have issue to build in @nft/templates There's a ChakraUI in each package.

I have no idea. Seems more like an issue with a webpack config. Make sure the version of chakra and all storybook deps are the same between templates and components

@achampagnedev
Copy link
Contributor

@NicolasMahe Do you think these 2 could be related? liteflow-labs/nft#2219. It works fine in @nft/components but have issue to build in @nft/templates There's a ChakraUI in each package.

I have no idea. Seems more like an issue with a webpack config. Make sure the version of chakra and all storybook deps are the same between templates and components

Ok yes, I already checked and they are the same that's why I asked, I can see it mention Webpack, just wondering why templates would trigger a webpack error with all the same packages related to chakra and storybook with same versions. Thanks

@antho1404 antho1404 transferred this issue from another repository Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants