-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten deps #55
Comments
@NicolasMahe Do you think these 2 could be related? https://github.com/liteflow-labs/nft/pull/2219. It works fine in |
I have no idea. Seems more like an issue with a webpack config. Make sure the version of chakra and all storybook deps are the same between templates and components |
Ok yes, I already checked and they are the same that's why I asked, I can see it mention Webpack, just wondering why templates would trigger a webpack error with all the same packages related to chakra and storybook with same versions. Thanks |
We currently have Chakra installed multiple time:
We should have only have one installation of chakra, any major libs actually, and make sure in the future that deps are flatten to avoid having different versions.
This is the source of issue #21.
I created a draft PR to test and it's working well:
https://github.com/liteflow-labs/nft/pull/1988
Need to redo the PR properly without removing all the extra deps to make it work.
The text was updated successfully, but these errors were encountered: