Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR #20

Open
literalpie opened this issue Jan 7, 2023 · 1 comment
Open

SSR #20

literalpie opened this issue Jan 7, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@literalpie
Copy link
Owner

Currently, we only render stories in dev mode, meaning we don't exercise and serialization logic.

If someone is depending on this while developing, that is a bad limitation - something might work in storybook, but not in a real app.

@literalpie literalpie added the enhancement New feature or request label Jan 16, 2023
@literalpie
Copy link
Owner Author

I took a stab at trying to get ssr stuff working with qwik+sb. I did what I assume is the "easy part". I updated the render function to use renderToString. It works for static components, but crashes whenever there's a signal in the component with "If qSerialize is true then fnStr must be provided".

https://github.com/literalpie/storybook-framework-qwik/tree/ssr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant