Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qwikCityDecorator breaks static build #25

Open
literalpie opened this issue Jan 12, 2023 · 2 comments
Open

qwikCityDecorator breaks static build #25

literalpie opened this issue Jan 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@literalpie
Copy link
Owner

No description provided.

@DustinJSilk
Copy link
Contributor

I'll dig into this issue next week!

@literalpie
Copy link
Owner Author

That would be great! if you don't find an easy solution, I'd also be open to just removing the decorator. But then there's the question of whether a consumer will be able to use qwik-city features if they wrap components in the mock provider on their own. Does your use qwik+storybook use qwik-city? I wonder how common this use-case is.

Also, if it's difficult to make the vite configuration work both with and without qwik-city, we could probably have a storybook addon: storybook-framework-qwik/qwik-city so people can opt-in to the qwik-city stuff only if they need it. (and the addon could apply the decorator automatically)

@literalpie literalpie added the bug Something isn't working label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants