Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename base62.ts to base62x.ts #1

Closed
wadelau opened this issue Apr 29, 2020 · 2 comments
Closed

rename base62.ts to base62x.ts #1

wadelau opened this issue Apr 29, 2020 · 2 comments

Comments

@wadelau
Copy link

wadelau commented Apr 29, 2020

The script:src/lib/encodings/base62.ts would be better to be renamed to src/lib/encodings/base62x.ts as the original name may lead to misunderstanding as to the actual base62, i.e., 0-61.
In fact this base62.ts is to present code number with 0-63. rt?

@fenying
Copy link
Contributor

fenying commented May 5, 2020

Oh, u r right. I will fix this later. Thank you.

@fenying
Copy link
Contributor

fenying commented May 6, 2020

Fixed in v2.2.0

@fenying fenying closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants