Bug: Msgspec constraints ignored in MsgspecDTO

[9128305]

Discussed in https://github.com/orgs/litestar-org/discussions/3025

^{Originally posted by 9128305 January 25, 2024}
Msgpec constraint here is ignored when sending {"foo": "t"}. What am I doing wrong?

from typing import Annotated

import msgspec
from litestar import post, Litestar
from litestar.dto import MsgspecDTO


class Request(msgspec.Struct):
    foo:  Annotated[str, msgspec.Meta(min_length=3,)]


@post("/example/", dto=MsgspecDTO[Request],sync_to_thread=False)
def example(data: Request) -> Request:
    return data


app = Litestar([example])

[9128305]

I checked code and DTOFieldDefinition skips Msgpec.Meta(...) for annotation, so new struct field has only str type

[peterschutt]

Thanks @9128305 - we should be copying these constraints onto the transfer models.

[9128305]

Should be Annotated type annotation splitted to unwrapped and metadata? Or is viable only for msgspec?

litestar/litestar/typing.py

Line 495 in 6e4e530

unwrapped, metadata, wrappers = unwrap_annotation(annotation if annotation is not Empty else Any)

[peterschutt]

Should be Annotated type annotation splitted to unwrapped and metadata? Or is viable only for msgspec?

litestar/litestar/typing.py

Line 495 in 6e4e530

unwrapped, metadata, wrappers = unwrap_annotation(annotation if annotation is not Empty else Any)

Sorry, I don't understand the question, can you rephrase or give an example?

[github-actions]

This issue has been closed in #3113. The change will be included in the upcoming patch release.

[github-actions]

A fix for this issue has been released in v2.6.2