Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LifespanHandler memory stream cleanup #3836

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

provinzkraut
Copy link
Member

Fix a dangling anyio stream in LifespanHandler.

Closes #3834.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (b2adb0d) to head (5d99868).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3836   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         332      332           
  Lines       15472    15499   +27     
  Branches     1701     1703    +2     
=======================================
+ Hits        15226    15253   +27     
  Misses        113      113           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@provinzkraut provinzkraut changed the title fix resource handling fix: LifespanHandler memory stream cleanup Oct 20, 2024
Copy link

sonarcloud bot commented Oct 20, 2024

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3836

@provinzkraut provinzkraut merged commit 5255ec3 into main Oct 21, 2024
26 checks passed
@provinzkraut provinzkraut deleted the fix-memory-stream-shutdown branch October 21, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ResourceWarning: Unclosed <MemoryObjectReceiveStream> with AsyncTestClient and anyio>=4.4
2 participants