Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to Test-IsBannedWord to skip inbound normalization #23

Open
ryannewington opened this issue Aug 2, 2019 · 0 comments
Open
Assignees
Labels
enhancement New feature or request pinned

Comments

@ryannewington
Copy link
Member

suggestion....
you have Test-IsBannedWord which normalizes and it gives an unexpected result, IMHO

for example:
"activedirectory" is in the Banned Words list

[1] Test-IsBannedWord "activedirectory" returns TRUE (expected)
[2] Test-IsBannedWord "activedirect0ry" returns TRUE (expected)
[3] Test-IsBannedWord "@ctivedirectory" returns FALSE (not expected)

with the last one it took some time to understand and I think the issue is due to the normalization rules where numbers and symbols at the beginning and end are stripped

Suggestion:
Test-IsBannedWord --> no normalization and just to test is a word in its form is in the banned word list
Test-IsBannedPassword --> supporting the actual password and the password after normalization rules

still does not solve the issue that I would be able to use @ctivedirectory as a password. The only thing I can think of is to test both the actual password and the stripped version after using normalization rules. Would require additional processing

Originally posted by @zjorz in #22 (comment)

@ryannewington ryannewington self-assigned this Oct 27, 2019
@ryannewington ryannewington added enhancement New feature or request pinned labels Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

1 participant