Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ipfs://CIDv0 to case-insensitive CIDv1 before making the request #30

Closed
lidel opened this issue Jun 5, 2023 · 0 comments · Fixed by #34
Closed

Convert ipfs://CIDv0 to case-insensitive CIDv1 before making the request #30

lidel opened this issue Jun 5, 2023 · 0 comments · Fixed by #34
Assignees

Comments

@lidel
Copy link
Collaborator

lidel commented Jun 5, 2023

While the ecosystem moves towards base insensitive CIDv1 in Base32,
we still have a lot of data addressed with CIDv0 (case-sensitive Base58btc).

Unfortunately, the authority component of URL entered in the address bar gets force-lowercased, which breaks the case-sensitive CIDv0 identifier:

ipfs://QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnRipfs://qmbwqxbekc3p8tqskc98xmwnzrzdtrlmimpl8wbutgsmnr

This is the same problem as ipfs/ipfs-companion#1006 (more examples there).

As we've discussed today, it would be a big UX win if as part of this project we detect CIDv0 passed to ipfs:// and fix it up by converting it to case-insentive CIDv1, allowing users to load legacy CIDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants