Diff to upstream #1

John-LittleBearLabs · 2024-05-10T14:12:38Z

Showing diff

fix: EINVAL when spawning on Windows

…n renderer (electron#41875) * fix: nativeImage.createThumbnailFromPath in renderer * also fix shell.openExternal

…n#41211) Don't check for Desktop Environment in unity_service.cc

* build: enable perfetto in Chromium * refactor: delete TracingControllerImpl * fix: TraceObject isn't present when v8_use_perfetto is true * fix: update lib/internal/http for perfetto * chore: remove stray log

* refactor: use std::erase() in WebContentsPreferences::~WebContentsPreferences() * refactor: use std::erase() in WindowList::RemoveWindow() * refactor: use std::erase() in ElectronBindings::EnvironmentDestroyed() * refactor: use std::erase() in CleanedUpAtExit::~CleanedUpAtExit() * refactor: use std::erase_if() in ElectronBrowserContext::RevokeDevicePermission() * refactor: use std::erase_if() in UsbChooserController::GotUsbDeviceList() * refactor: move DoesDeviceMatch() out of class into anonymous namespace

…1916)

…ectron#41904) Co-authored-by: zhangqi.67 <zhangqi.67@bytedance.com>

…41926)

…lectron#41911) refactor: address changes and fix errors in chrome://accessibility

Update tutorial-6-publishing-updating.md

)

* build: test the Mac runner space * build: baby steps, super basic checkout * chore: simplify depot-tools * build: try a sync * build: fix path * build: pass different URL for sync * build: gclient sync with --verbose * debug: add logging for mtime cache * build: add psuedocode for Azure workflow, add workflow_dispatch * build: enable ssh access to runners * build: test azure upload without full sync * build: full sync and cache upload test * build (WIP): mock out download logic * build: remove sync, try disk space prune * build: lets try it again, lads * ci: add cache downloading wip * fix: correct json parsing * chore: use depshash and fix output syntax * chore: rework depshash state and delete more * refactor: split checkout to Linux runner * fix: depot_tools get on Linux * fix: add infra/3pp/tools/swift-format handling * chore: move to patch file in build as well * chore: misc cleanup of env steps * chore: add fix sync step * build: use tar file, strip .git dirs * build: set GIT_CACHE_PATH outside of src * ci: fix cache prefix, add check for ssh debug * fix: fix tar pack/unpack * build: add reclient support & ninja build step * chore: clean up reclient round 1 * fix: grab ELECTRON_RBE_JWT from secrets * chore: run tmate if debug logging enabled * chore: move ulimit setting * fix: missing GN gen env vars * fix: workaround packed-refs issue * chore: fixup PATH usage * chore: remove GIT_CACHE env var * fix: call pack refs manually * fix: add RBE_experimental_credentials_helper_args * chore: whoops we need electron_node/deps/v8 actually * fix: we need electron_node/deps/openssl too * build: load build-tools & xcode * build: add dist, chromedriver & mksnapshot * build: add test job, download artifacts * Cache non-generated build artifacts * chore: set download path explicitly * chore: load-xcode is called by e build * Add codesigning certificate step * Add Test Step * Try without codesigning just to get tests running * Add depot_tools to PATH in test * Persist src/buildtools/mac * chore: use script/yarn test directly * Build Node.js Headers for caching * Add initial matrix for mas build * Fix GN_EXTRA_ARGS generation syntax * Fix BUILD_TYPE interpolation * Use matrix in test correctly * feat: add publish config, alter release-build script * build: force trigger the first workflow * build: oops * Ensure env vars escaped * Move GN_EXTRA_ARGS to gn gen step * chore: rename yml to match convention * ci: fix helperPath calls in action configs * chore: try setting directly * fix: switch to mas config * chore: Testing -> Default * Re-enable darwin build * Use mas JSON config * refactor: extract artifact logic to bash scripts * refactor: build MAS after darwin * chore: move to script/actions * chore: use Node.js 20.11.x * Don't fail-fast in tests * build: tweak release script * build: remove macos-publish.yml * build: change action to trigger on publish workflow dispatch * chore: remove SSH debugging using action-tmate * build: do not disable CircleCI config * chore: switch away from cURL for AzureCLI * chore: move evm.mas.json to .github/workflows/config * chore: remove publish logic from initial build flow * build: add patchup check for non-release builds * build: pin build-tools to sha 2bb63e2 --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>

…tron#41960) fix: setTitleBarOverlay should be implemented on BaseWindow

* chore: fix removeSupercededStackUpdates for generating notes * add early stop for less than * Update script/release/notes/notes.js Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * clean up comparison functionality * add tests --------- Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

fix: requestFullscreen from WebContentsView

* chore: disable tests that require nut.js * fixup! chore: disable tests that require nut.js

docs: update formatting for mdx3 compat

…#42042) * Keep GitHub Actions up to date with GitHub's Dependabot Fixes software supply chain safety warnings like at the bottom right of https://github.com/electron/electron/actions/runs/8619491231 * [Keeping your actions up to date with Dependabot](https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot) * [Configuration options for the dependabot.yml file - package-ecosystem](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#package-ecosystem) * Apply suggestion from code review * chore: fully remove groups --------- Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

…ctron#42075) Bumps [actions-cool/issues-helper](https://github.com/actions-cool/issues-helper) from 3.3.3 to 3.6.0. - [Release notes](https://github.com/actions-cool/issues-helper/releases) - [Changelog](https://github.com/actions-cool/issues-helper/blob/main/CHANGELOG.md) - [Commits](actions-cool/issues-helper@2753289...a610082) --- updated-dependencies: - dependency-name: actions-cool/issues-helper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…n#42073) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.0 to 3.25.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e8893c5...d39d31e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ron#42030)

…lectron#42076)

* chore: bump chromium in DEPS to 128.0.6613.18 * chore: e patches all to make GH actions happy --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

…#43202) refactor: simplify window moveAbove/moveTop impl on macOS Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* refactor: remove unused code in HidChooserContext::DeviceRemoved() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError() Co-authored-by: Charles Kerr <charles@charleskerr.com> * refactor: use structured bindings for readability Co-authored-by: Charles Kerr <charles@charleskerr.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>

* docs: deprecate `BrowserView` Reference: electron#35658 Co-authored-by: Piotr Płaczek <piotrpdev@gmail.com> * docs: deprecate `webContents.goToIndex(index)` Reference: https://github.com/electron/electron/pull/41752/files#diff-18ed6a5b5a9084c976509502962b7f05989a8bd13a2ba3dc02868056938c03b6R1165-R1167 Co-authored-by: Piotr Płaczek <piotrpdev@gmail.com> * docs: deprecate some protocol methods Reference: https://github.com/electron/electron/pull/36674/files#diff-74861ecada868821b139e79f244ea32b840a93f60de572d585117a0ff8d165c8R380 Co-authored-by: Piotr Płaczek <piotrpdev@gmail.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Piotr Płaczek <piotrpdev@gmail.com>