Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

netlink-packet-route: re-introduce rich NLAs #199

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Conversation

little-dude
Copy link
Owner

The Netlink API is not stable, and the packet format may change from
one kernel version to another or even from a CPU architecture to
another. In an ideal world, we'd have conditional compilation based on
the kernel version and/or system architecture. But at the moment, we
just follow whatever is the current format at the time of
implementation.

This led to several issues, which prompted a PR that simply removes
the problematic NLAs:
#51

However, not parsing these NLAs means allocating a buffer and do the parsing a
posteriori which is wasteful and inconvenient. Therefore, this commit
re-introduces these problematic NLAs but behind a feature flag.

@little-dude
Copy link
Owner Author

cc @pinkisemils

This should not affect you though because this is opt-in.

@little-dude little-dude force-pushed the rich-attributes branch 2 times, most recently from eaf348d to dce481f Compare November 22, 2021 20:36
The Netlink API is not stable, and the packet format may change from
one kernel version to another or even from a CPU architecture to
another. In an ideal world, we'd have conditional compilation based on
the kernel version and/or system architecture. But at the moment, we
just follow whatever is the current format at the time of
implementation.

This led to several issues, which prompted a PR that simply removes
the problematic NLAs:
#51

However, not parsing these NLAs means allocating a buffer and do the parsing a
posteriori which is wasteful and inconvenient. Therefore, this commit
re-introduces these problematic NLAs but behind a feature flag.
@pinkisemils
Copy link
Contributor

I did try building our app with these changes, but there were some dependency issues. However, the changes look good in so far as they won't break anything for us. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants