This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
netlink-packet-route: re-introduce rich NLAs #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Netlink API is not stable, and the packet format may change from
one kernel version to another or even from a CPU architecture to
another. In an ideal world, we'd have conditional compilation based on
the kernel version and/or system architecture. But at the moment, we
just follow whatever is the current format at the time of
implementation.
This led to several issues, which prompted a PR that simply removes
the problematic NLAs:
#51
However, not parsing these NLAs means allocating a buffer and do the parsing a
posteriori which is wasteful and inconvenient. Therefore, this commit
re-introduces these problematic NLAs but behind a feature flag.