Smarter service

[garak]

Currently, there is only a lonely service, that just exposes underlying library.
It would be nice to offer a smarter service. This is the example provided in the bundle:

    public function streamAction()
    {
        // create an empty object
        $phpExcelObject = $this->createXSLObject();
        // create the writer
        $writer = $this->get('phpexcel')->createWriter($phpExcelObject, 'Excel5');
        // create the response
        $response = $this->get('phpexcel')->createStreamedResponse($writer);
        // adding headers
        $response->headers->set('Content-Type', 'text/vnd.ms-excel; charset=utf-8');
        $response->headers->set('Content-Disposition', 'attachment;filename=stream-file.xls');
        $response->headers->set('Pragma', 'public');
        $response->headers->set('Cache-Control', 'maxage=1');

        return $response;
    }

It's too way long. All the headers should be set by a service, and the final action should be something like this:

    public function streamAction()
    {
        // create an empty object
        $phpExcelObject = $this->createXSLObject();
        // create the writer
        $writer = $this->get('phpexcel')->createWriter($phpExcelObject, 'Excel5');
        // create the response
        $response = $this->get('smart_phpexcel')->createStreamedResponse($writer);

        return $response;
    }

[liuggio]

@garak I don't really like hiding the cache and the filename,
but I do really like the idea of reducing the code...

WDYT about

        $response = $this->get('phpexcel')->applyStandardHeader($response, filename);
// or
       $response = $this->get('phpexcel')->createStreamedResponseWithStandardHeader($writer, $filename)

[garak]

Yes yes, of course I was just giving an example, I agree that hiding too much is not good.

[liuggio]

which choice you prefer between the 2?

applyStandardHeader
createStreamedResponseWithStandardHeader

can you provide PR?

[garak]

I'll work on a PR in the next long weekend

[liuggio]

👍

[liuggio]

@garak ping