New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel terminate instead of reasponse #57

Open

eMerzh opened this issue Oct 25, 2015 · 1 comment

eMerzh commented Oct 25, 2015

Hi,
I'm not an expert, but...

if i'm correct,
you currently attach to "KernelEvents::RESPONSE" to compute the stats from the collectors...

but if you use KernelEvents::TERMINATE it has several improvement like,

not slowing down the user response,
happening a bit further in the chain, so some things might be a bit more accurate (timing, memory, ...)
no?

what do you think?

Collaborator

dav-m85 commented Oct 30, 2015

Sounds like a good point to me. What do you think @liuggio ? Any reason why we would not move collector further in the processing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment