Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a ProcessInterface #6

Closed
EmanueleMinotto opened this issue Oct 1, 2015 · 2 comments
Closed

Create a ProcessInterface #6

EmanueleMinotto opened this issue Oct 1, 2015 · 2 comments
Labels
bug enhancement

Comments

@EmanueleMinotto
Copy link
Collaborator

ClosureProcess|Process (ref) isn't allowed as a requirement so anything could be passed as $process, to prevent this behaviour a ProcessInterface should be declared.
@liuggio
Copy link
Owner

liuggio commented Oct 1, 2015

👍

@EmanueleMinotto
Copy link
Collaborator Author

Related bug:

1) Liuggio\Spawn\SpawnTest::shouldExecuteASimpleCallableAndGetTheOutputAndReturnValueCorrectly
Argument 2 passed to Liuggio\Spawn\Process\Channel\Channels::assignAProcess() must be an instance of Liuggio\Spawn\Process\Process, instance of Liuggio\Spawn\Process\ClosureProcess given, called in src/Process/Processes.php on line 117 and defined

src/Process/Channel/Channels.php:44
src/Process/Processes.php:117
vendor/symfony/event-dispatcher/EventDispatcher.php:160
vendor/symfony/event-dispatcher/EventDispatcher.php:48
src/Consumer/ConsumerListener.php:100
vendor/symfony/event-dispatcher/EventDispatcher.php:160
vendor/symfony/event-dispatcher/EventDispatcher.php:48
src/Process/Processes.php:162
src/Process/Processes.php:142
src/SpawnLoop.php:60
tests/SpawnTest.php:29

@liuggio liuggio reopened this Oct 5, 2015
@liuggio liuggio closed this as completed Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EmanueleMinotto @liuggio