Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the rescaling of roughness in Stage 2. #42

Open
K-nowing opened this issue Jan 10, 2024 · 2 comments
Open

About the rescaling of roughness in Stage 2. #42

K-nowing opened this issue Jan 10, 2024 · 2 comments

Comments

@K-nowing
Copy link

Thank you for your work!

From the code of stage 2, why do you set the min of roughness 0.04?

rmax, rmin = 1.0, 0.04**2

Is there a physical reason for this, or is it just a hyperparameter?

Thanks!

@liuyuan-pal
Copy link
Owner

Hi, this is only a hyperparameter. When I use 0, there may be some numerical issues when computing the BRDF and there are no perfectly smooth objects. Thus, I chose this 0.04 threshold. Thank you!

@K-nowing
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants