From 3c562e0041f093b55b684b78e75643938248e918 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonatan=20K=C5=82osko?= Date: Mon, 15 Apr 2024 14:44:19 +0800 Subject: [PATCH] Respect automatically reevaluating cells in app sessions --- lib/livebook/session/data.ex | 3 --- test/livebook/session/data_test.exs | 20 -------------------- 2 files changed, 23 deletions(-) diff --git a/lib/livebook/session/data.ex b/lib/livebook/session/data.ex index a55465e19f7..9630b237135 100644 --- a/lib/livebook/session/data.ex +++ b/lib/livebook/session/data.ex @@ -2516,9 +2516,6 @@ defmodule Livebook.Session.Data do end) end - defp update_reevaluates_automatically({data, _} = data_actions) when data.mode == :app, - do: data_actions - defp update_reevaluates_automatically({data, _} = data_actions) do eval_parents = cell_evaluation_parents(data) diff --git a/test/livebook/session/data_test.exs b/test/livebook/session/data_test.exs index b2749ef8d39..635897b1020 100644 --- a/test/livebook/session/data_test.exs +++ b/test/livebook/session/data_test.exs @@ -4325,26 +4325,6 @@ defmodule Livebook.Session.DataTest do assert {:ok, %{app_data: %{status: %{lifecycle: :shutting_down}}}, [:app_terminate]} = Data.apply_operation(data, operation) end - - test "does not automatically reevaluate" do - data = - data_after_operations!(Data.new(mode: :app), [ - {:insert_section, @cid, 0, "s1"}, - {:insert_cell, @cid, "s1", 0, :code, "c1", %{}}, - {:insert_cell, @cid, "s1", 1, :code, "c2", %{}}, - {:set_cell_attributes, @cid, "c2", %{reevaluate_automatically: true}}, - {:set_runtime, @cid, connected_noop_runtime()}, - evaluate_cells_operations(["setup"]), - {:queue_cells_evaluation, @cid, ["c1"]}, - {:add_cell_evaluation_response, @cid, "c1", @input, eval_meta()}, - evaluate_cells_operations(["c2"], bind_inputs: %{"c2" => ["i1"]}) - ]) - - operation = {:set_input_value, @cid, "i1", "stuff"} - - assert {:ok, %{app_data: %{status: %{execution: :executed}}}, _actions} = - Data.apply_operation(data, operation) - end end describe "transform_selection/2" do