Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: ticket redemption race condition leads to not properly setting fields in DB that mark the ticket as redeemed #1626

Closed
kyriediculous opened this issue Oct 12, 2020 · 0 comments
Labels
type: bug Something isn't working

Comments

@kyriediculous
Copy link
Contributor

Describe the bug
After receiving a winning ticket and popping it from the ticketQueue there was a race condition that tried to redeem the winning ticket twice within the same block.

This caused the redeemedAt and txHash fields to not be set within the database and this winning ticket to be retried over and over.

While this issue would be fixed by #1598 which prevents redeeming used tickets and marks them as redeemed, that PR does not fix the race condition that occured here.

Expected behavior
To only send a single transaction for a winning ticket

@kyriediculous kyriediculous added type: bug Something isn't working pm labels Oct 12, 2020
@hthillman hthillman removed the pm label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants