You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
During discovery, a B will call GetOrchestrator() on all available Os. Once B receives a sufficient number of responses, it will cancel the remaining requests using a context. The cancellation of these requests results in a ton of error messages indicating that the GetOrchestrator() call failed due to a cancellation. As a result, the logs of B can become flooded with these error logs even though the logs don't indicate any issues with the Os because it was the B that cancelled the request.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Silence discovery error logs if the GetOrchestrator() call was cancelled.
This draft PR outlines one potential approach to silencing those discovery error logs by using the new errors Is() API. But, the code is untested and it is not clear if the Is() API is going to work as expected - I'm not sure if the function that returns the error would need to support error wrapping/unwrapping. An alternative would be to check if the error string contains a context cancellation message. Being able to use the errors Is() API could be cleaner though as I think this type of error checking is what it is meant for.
The text was updated successfully, but these errors were encountered:
Had to wrap the errors instead of concatenating the messages as the API docs of errors.Is() suggests. Works as expected, tested it on rinkeby and only get insufficient sender reserve errors now.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
During discovery, a B will call GetOrchestrator() on all available Os. Once B receives a sufficient number of responses, it will cancel the remaining requests using a context. The cancellation of these requests results in a ton of error messages indicating that the GetOrchestrator() call failed due to a cancellation. As a result, the logs of B can become flooded with these error logs even though the logs don't indicate any issues with the Os because it was the B that cancelled the request.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Silence discovery error logs if the GetOrchestrator() call was cancelled.
This draft PR outlines one potential approach to silencing those discovery error logs by using the new errors Is() API. But, the code is untested and it is not clear if the
Is()
API is going to work as expected - I'm not sure if the function that returns the error would need to support error wrapping/unwrapping. An alternative would be to check if the error string contains a context cancellation message. Being able to use the errorsIs()
API could be cleaner though as I think this type of error checking is what it is meant for.The text was updated successfully, but these errors were encountered: