Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to the footer version and commit sha #134

Closed
larouxn opened this issue Sep 5, 2019 · 0 comments · Fixed by #135
Closed

Add links to the footer version and commit sha #134

larouxn opened this issue Sep 5, 2019 · 0 comments · Fixed by #135
Assignees
@larouxn
Labels
feature New feature or request

Comments

@larouxn
Copy link
Contributor

larouxn commented Sep 5, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
The version number and commit sha in the footer don't link to the version and commit sha on GitHub, respectively.

Describe the solution you'd like
Add dynamic links to the release/commit sha.
`https://github.com/liyasthomas/postwoman/releases/tag/${release}

Describe alternatives you've considered
No real alternatives. Just adding links.

Additional context
Screen Shot 2019-09-04 at 14 59 27
https://github.com/liyasthomas/postwoman/blob/0350355626621d24cb3442a313e22655dfc3b114/layouts/default.vue#L38-L41
This is the footer release and commit sha I'm talking about.
@larouxn larouxn added the feature New feature or request label Sep 5, 2019
@larouxn larouxn self-assigned this Sep 5, 2019
@larouxn larouxn mentioned this issue Sep 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larouxn larouxn

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linkify footer version and commit sha
1 participant
@larouxn