Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent version name #141

Closed
larouxn opened this issue Sep 8, 2019 · 2 comments
Closed

Inconsistent version name #141

larouxn opened this issue Sep 8, 2019 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@larouxn
Copy link
Contributor

larouxn commented Sep 8, 2019

Describe the bug
Sometimes our version name is prepending with v, something it's not. This breaks the links added in #135.

In prod we don't have a v:
Screen Shot 2019-09-08 at 23 33 50

In dev we do have a v:
Screen Shot 2019-09-08 at 23 33 54

To Reproduce
Steps to reproduce the behavior:

  1. Go to the app in prod | https://postwoman.io
  2. Got to the app in dev | http://localhost:3000/
  3. Compare the release version tags in the footer
  4. Notice they're different and the link is broken in prod

Expected behavior
They're the same, v0.1.0 on both, in this case.

@liyasthomas
Copy link
Member

liyasthomas commented Sep 8, 2019

  • In package.json, version is specified without v and we can't add v to package.json
  • In GitHub releases, tag is specified with v

In dev mode, version is picked from package.json
Whereas at prod build, version is taken from env tag, ie: Release Tag

This might be the reason why at dev mode, version link is broken and at production link is working. We need to unify source from which tag is selected. I think we should prefer getting version from release tag

@liyasthomas liyasthomas added the documentation Improvements or additions to documentation label Sep 15, 2019
@larouxn
Copy link
Contributor Author

larouxn commented Sep 15, 2019

Everything seems to working as desired now.
Screen Shot 2019-09-15 at 19 52 55
Screen Shot 2019-09-15 at 19 53 05

@larouxn larouxn closed this as completed Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants