Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credentials are still being included in Permalink even when "Include in URL" is turned off #227

Closed
reefqi037 opened this issue Oct 29, 2019 · 3 comments · Fixed by #228
Closed

Credentials are still being included in Permalink even when "Include in URL" is turned off #227

reefqi037 opened this issue Oct 29, 2019 · 3 comments · Fixed by #228

Comments

@reefqi037
Copy link
Contributor

Describe the bug
Include in URL toggle only include/exclude auth parameter.

To Reproduce
Steps to reproduce the behavior:

  1. Set Authentication Type to Basic or Bearer Token
  2. Set the Username and Password or Token
  3. Toggle Include in URL button on and off
  4. See the httpUser and httpPassword or bearerToken left in URL

Expected behavior
Include in URL toggle button should include/exclude not only auth, but httpUser, httpPassword and bearerToken too.

Screenshots
auth

Additional context
Related with #178 and #215
@NBTX
Copy link
Contributor

NBTX commented Oct 29, 2019

Ah! I know the cause, I'll submit a PR as soon as I get home.

@reefqi037 reefqi037 mentioned this issue Oct 29, 2019
Merged
@reefqi037
Copy link
Contributor Author

Yeah, thought you will figured it out since you wrote that part. I have submit a PR too but feel free to make another. I'm new to vue and still learning 😬

@NBTX
Copy link
Contributor

NBTX commented Oct 29, 2019

Nope your PR works fine!

@NBTX NBTX closed this as completed in #228 Oct 29, 2019
NBTX added a commit that referenced this issue Oct 29, 2019
@NBTX
Merge pull request #228 from reefqi037/toogle-exclude-credentials
8c98e7f 
Fix #227 Exclude credentials from permalink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #227 Exclude credentials from permalink reefqi037/postwoman
2 participants
@NBTX @reefqi037