-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend syntax highlighting with ACE for pre-request script textarea #235
Comments
@sblasa are you still interested in taking this? |
HighlightJS is already implemented in the PW. |
@liyasthomas and @nickpalenchar yes, I'm still interested in this. So, I'm using hiighlight.js instead, since highlight is already there; therefore use that. to extend syntax highlighting for pre-request script. |
@sblasa thought I should ping you to get the latest updates on this issue...! If you need any help, ping me. |
@liyasthomas Hi! I pulled down the latest changes--and running on my local. I'll ping you shortly for some help. Thanks! |
@liyasthomas Hi, noticed that the reference for highlight.js will be removed from pages/index.vue with Replace highlight.js with ace editor #292 . So we probably won't use highlight.js to create the feature since it has been removed? Use Ace Editor instead? Thanks! |
@liyasthomas Okay, thanks for confirming. 👍 |
@sblasa ace is in production (master branch) now! Refer the code snippets from there. |
Yeah, I tried implementing two-way binding (v-model) onto the Ace Editor component (components/ace-editor.vue) but it had some issues with the re-render (cursor keeps staying in the first col of first line), so I dropped it... Can somebody go into fixing that ? Or can we move Ace Editor stuff to a library (like a Ace Editor wrapper for Vue) |
I think v-model doesn't work on Ace. I too tried and failed doing it. |
Can we look into libraries providing Vue wrappers from Ace ? |
Ooooh, if nobody is working on it, I will try implementing it and migrate the necessary views. If nobody is working on it, can I get an assign ? |
Related to #218
Is your feature request related to a problem? Please describe.
No syntax highlighting might confuse users in pre-request scritps. It could look like they're writing in plaintext, and common typos won't be as apparent.
Describe the solution you'd like
Simple syntax highlighting. Things like basic javascript types should be highlighted. Nothing too fancy needed.
Describe alternatives you've considered
Going without, but syntax highlighting looks more l33t.
Additional context
@sblasa has done some research on this after reaching out on #91
The text was updated successfully, but these errors were encountered: