Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [UI] [Mobile] Get results not scrollable. #266

Closed
AtomicMaya opened this issue Nov 5, 2019 · 6 comments
Closed

[BUG] [UI] [Mobile] Get results not scrollable. #266

AtomicMaya opened this issue Nov 5, 2019 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@AtomicMaya
Copy link

Describe the bug
When GETting a larger quantity of data, the Results area does not allow scrolling (the page gets scrolled instead).

To Reproduce
Steps to reproduce the behavior:

  1. On Mobile, go to PW
  2. Make a GET request, where the received data exceeds the number of lines in the text area (tried with 2749, because I like breaking things).
  3. Scroll down to the Results area
  4. Try scrolling the Text Area.

Expected behavior
Scroll should be deferred to Text Area instead of page.

Screenshots
photo_2019-11-05_10-55-34

Smartphone (please complete the following information):

  • Device: Xiaomi Redmi Note 7
  • OS: Android 9.something
  • Browser stock, Chrome, Firefox Focus, Opera
  • Version latest
@liyasthomas liyasthomas added the bug Something isn't working label Nov 5, 2019
@hosseinnedaee
Copy link
Contributor

hosseinnedaee commented Nov 8, 2019

I checked it on the same device and it works fine for me (Chrome & Opera).

@liyasthomas
Copy link
Member

Normal responses with LOC < 100 works fine.
Huge payload breaks HighlightJS render. Issue will persist until syntax highlighting is migrated to ace.

@hosseinnedaee hosseinnedaee self-assigned this Nov 8, 2019
@hosseinnedaee
Copy link
Contributor

I will work on it.

@liyasthomas
Copy link
Member

liyasthomas commented Nov 8, 2019

Currently, response is syntax highlighted in <pre><code> tags for highlightJS implementation. Remove hljs and implement alternative (such as ace) that supports textarea highlighting

@hosseinnedaee
Copy link
Contributor

Currently, response is syntax highlighted in <pre><code> tags for highlightJS implementation. Remove hljs and implement alternative (such as ace) that supports textarea highlighting

Okay

@AtomicMaya
Copy link
Author

Yup, This was fixed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants