Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:SSE onclose handle #349

Closed
FatDoge opened this issue Nov 27, 2019 · 0 comments
Closed

fix:SSE onclose handle #349

FatDoge opened this issue Nov 27, 2019 · 0 comments

Comments

@FatDoge
Copy link

FatDoge commented Nov 27, 2019 •
edited
Loading

Describe the bug
If u click the stop button in SSE test page, the log info doesn't appear.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'realtime -> sse'
  2. Click on 'start'
  3. Waiting for the connection start
  4. Click on 'stop'
  5. the connection closed but the UI did not change.

Expected behavior
Log the info, change the button.

Screenshots
I have clicked the stop button,and the connection has been closed, but the botton did not change, neither the log info did appear.
image

I have created a PR, just call the this.sse.onclosebefore the sse close handle.(Actually the sse doesn't have the onclose handle)
#347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FatDoge