Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom request method #398

Closed
JanoschDeurer opened this issue Dec 4, 2019 · 5 comments · Fixed by #400
Closed

Custom request method #398

JanoschDeurer opened this issue Dec 4, 2019 · 5 comments · Fixed by #400
Assignees
Labels
feature New feature or request

Comments

@JanoschDeurer
Copy link

Is your feature request related to a problem? Please describe.
Some APIs use custom request methods. For example the API of vault uses LIST do deliver secrets:
https://www.vaultproject.io/api/secret/kv/kv-v2.html#list-secrets

Describe the solution you'd like
It would be great to have a custom option that opens a text field where one can put in strings that describe the method.

Another solution is to just replace the dropdown with a text field.

Describe alternatives you've considered
I think for such APIs the only alternative is to use a different tool, but I really like postwoman :)

@liyasthomas
Copy link
Member

Will try to implement them.

@liyasthomas
Copy link
Member

method list have been adapted from https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods and since LIST is not an officially safe method, we can't list that in our default set of methods. But we've implemented an <input> box instead of <select> options, this allows user to type in any custom method they want. These custom methods could be used in endpoints that support those methods.

@liyasthomas liyasthomas self-assigned this Dec 4, 2019
@liyasthomas liyasthomas added the feature New feature or request label Dec 4, 2019
@liyasthomas
Copy link
Member

liyasthomas commented Dec 4, 2019

@JanoschDeurer can you do a quick verification of custom method feature?

Check out https://deploy-preview-400--postwoman.netlify.com and try out few custom methods you're familiar of.

Don't forget to use the endpoints that do support those methods. The default one doesn't seems to have support for custom methods.

@JanoschDeurer
Copy link
Author

Wow, that was fast 🤩, thank you so much. I tested it with a few of the custom methods that vault uses and it works.

@liyasthomas
Copy link
Member

liyasthomas commented Dec 5, 2019

Shoot suggestions and along with PRs 😌👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants