Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast URL entry #62

Closed
NBTX opened this issue Aug 25, 2019 · 20 comments · Fixed by #603
Closed

Fast URL entry #62

NBTX opened this issue Aug 25, 2019 · 20 comments · Fixed by #603
Assignees
Labels
feature New feature or request wip Work in progress

Comments

@NBTX
Copy link
Contributor

NBTX commented Aug 25, 2019

Is your feature request related to a problem? Please describe.
No.

Describe the solution you'd like
Similar to Postman's interface, I think we should make the URL entry a single bar at the top, with the method on the left. Then we should just parse the URL and fill in the relevant information.

We could keep the extra sections but this would make Postwoman a lot more intuitive and faster to use.

Describe alternatives you've considered
n/a

Additional context
image
As shown, Postman parses the URL as it is entered and automatically fills in the relevant sections.

@NBTX
Copy link
Contributor Author

NBTX commented Aug 25, 2019

I'm happy to implement this myself, but I wanted to open a discussion on the matter.

@liyasthomas
Copy link
Member

This fact might surprise you: other than seeing some screenshots on internet, I haven't used Postman or seen its UI (this is just because, my 7 year old pc can't afford to run another Electron app). Afterall, I didn't intend to create an alternative to Postman, in my opinion this project should outperform any other such tools, since its lightweight, faster & opensource.

If there's any feature we'd like to add, all are free to discuss here. Everything is better when there's freedom and customisation in it.

@liyasthomas liyasthomas added the feature New feature or request label Aug 25, 2019
@liyasthomas
Copy link
Member

@NBTX see #63 and share your thoughts. Me too think this is an essential feature somehow I forgot at the first place. My bad. Anyway thanks for pulling it up.

@NBTX
Copy link
Contributor Author

NBTX commented Aug 25, 2019

I'm actually only drawing the parallel to Postman's interface from experience, rather than because the names are similar, and this is the UI I'm used to - but this, as I said is something I would find useful.

I already very much prefer Postwoman because it's so much lighter. Even on my pretty decent systems Postman takes upwards of 7 seconds to start up, and then usually has several annoying pop ups to deal with.

@liyasthomas
Copy link
Member

#93 needs similar kinda approach

@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Sep 6, 2019
@liyasthomas liyasthomas mentioned this issue Sep 6, 2019
@terranblake
Copy link

@liyasthomas and @NBTX i'd like to take this one for hacktoberfest 😄

@liyasthomas
Copy link
Member

@terranblake you are free to contribute to this 🔥👌 assigning to you.

@terranblake
Copy link

@liyasthomas for this feature to be implemented, i do have a couple questions about a proposed design.

  1. can the path field be removed as a part of the solution?
  2. can i move the permalink and show code buttons below the url field on the same plane as import cURL?

@liyasthomas
Copy link
Member

liyasthomas commented Sep 28, 2019

@terranblake yes you can. permalink & show code can be moved to bottom of the section.

currently path is appended to request, you must resolve that while making changes.

there are bindings for path in various methods, you must resolve that too.

@NBTX
Copy link
Contributor Author

NBTX commented Sep 28, 2019

@terranblake I imagine you would just use the JavaScript URL object:
const target = new URL("https://example.com/test");

In which case you can just get .path, .host/.hostname, etc.
As @liyasthomas mentioned, path is in a separate variable so you will need to split the URL and handle them separately but part of the goal of this ticket is to have the entire URL (querystring and all) handled in a single input box as it is with postman.

So to answer your question, you can remove the path input box and have a single input box for the full URL but obviously we still need the path to be handled as a separate variable.

@terranblake
Copy link

Hopping on this one tonight. Will keep this issue updated.

@terranblake
Copy link

Image 2019-10-07 at 8 06 36 PM

This is what I have so far. Nothing too crazy.

@liyasthomas
Copy link
Member

@terranblake you tested? Any bugs?

@terranblake
Copy link

Query params are imported directly into the parameters section. I am having an issue with the Referer field of the request getting blown up...

@liyasthomas
Copy link
Member

Lemme take a look at it and possibly help you 🙂

@terranblake
Copy link

Alrighty. I'll fork. One sec

@terranblake
Copy link

Should be available on this branch

@terranblake terranblake mentioned this issue Oct 8, 2019
4 tasks
@liyasthomas liyasthomas added the wip Work in progress label Nov 8, 2019
@NBTX NBTX self-assigned this Nov 28, 2019
@dihmeetree
Copy link
Contributor

dihmeetree commented Feb 24, 2020

This seems to have been implemented. Can this be /closed? Or this still open for discussion? :) @NBTX @liyasthomas

@liyasthomas
Copy link
Member

liyasthomas commented Feb 24, 2020

I afraid this feature was incomplete and branch went stale. Lemme run some tests.

@liyasthomas liyasthomas linked a pull request Feb 25, 2020 that will close this issue
5 tasks
@liyasthomas liyasthomas reopened this Feb 25, 2020
@liyasthomas liyasthomas removed a link to a pull request Feb 25, 2020
5 tasks
@liyasthomas liyasthomas pinned this issue Feb 25, 2020
@JacobAnavisca
Copy link
Contributor

Heyo! Just made a PR for this #603
used a regex and I did some testing but might be good for others to try it out as well

@liyasthomas liyasthomas unpinned this issue Mar 1, 2020
AndrewBastin pushed a commit that referenced this issue Apr 11, 2023
* fix: cast prisma user object to user object

* chore: improved consistency

* chore: cast function renamed

---------

Co-authored-by: Mir Arif Hasan <arif.ishan05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request wip Work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants