Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body scroll after modal is open #766

Closed
ghost opened this issue Apr 13, 2020 · 5 comments
Closed

Body scroll after modal is open #766

ghost opened this issue Apr 13, 2020 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 13, 2020

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. In mobile
  2. Click 3 dots menu
  3. Click Shortcuts
  4. Now body is scrollable after the modal is open

Expected behavior
Scroll should be locked

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@liyasthomas
Copy link
Member

Scroll on "modal opened state" is a good thing.
Allows you to check data on body without closing modal.

@ghost
Copy link
Author

ghost commented Apr 13, 2020

Upgrading to vue 3 soon or after its stable release?

@liyasthomas
Copy link
Member

Hahaha. Only after stable release. And only if it's possible. All our codebase is spaghetti sauce 🤣

@ghost
Copy link
Author

ghost commented Apr 13, 2020

Off topic but are to using a ui framework, the design is awesome ❤️

@liyasthomas
Copy link
Member

No UI frameworks used. Each styles are written by ne ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant