Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Documentation Generated' response stacking past top of page if submit clicked enough times/fast enough #826

Closed
DGKSK8LIFE opened this issue Apr 30, 2020 · 6 comments

Comments

@DGKSK8LIFE
Copy link

Describe the bug
On the /doc route, if one clicks on generate documentation fast enough, the response oval shaped "tab" can stack almost infinitely, and clears over time; ie: there is no limit to how much it can stack.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /doc
  2. Click on 'Generate Documentation` rapidly with an empty array in import collections
  3. Response "tabs" will stack and block the button/stack above the top of the page

Expected behavior
There to be one notification or a verification that collections are actually imported before responding.

Screenshots
Unable to add screenshots, as they disappear quickly, but it happened.

@liyasthomas
Copy link
Member

Quick fix: Don't do that

@DGKSK8LIFE
Copy link
Author

Quick fix: Don't do that

Why not just implement a stacking limit?

@liyasthomas
Copy link
Member

The current hotfix clears all previous toasts before triggering another. So kinda same effect with a simpler approach.

@DGKSK8LIFE
Copy link
Author

The current hotfix clears all previous toasts before triggering another. So kinda same effect with a simpler approach.

Ok! Is it merged to master branch/deployed yet or?

@liyasthomas
Copy link
Member

Merged to master 14 hours ago.

@DGKSK8LIFE
Copy link
Author

Merged to master 14 hours ago.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants