Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with the renderer mixins #1008

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Conversation

AndrewBastin
Copy link
Member

This PR tries to fix some of the bugs related to issue #994

It mostly fixes crashes caused by the proxy error and fixes the issue with the Unexpected token during JSON parsing.

@AndrewBastin AndrewBastin added the bug fix This fixes a bug label Jul 21, 2020
@AndrewBastin AndrewBastin added this to the v2.0 milestone Jul 21, 2020
@AndrewBastin AndrewBastin self-assigned this Jul 21, 2020
@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 80e0a630-cb06-11ea-96be-d1d226963d5e

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 58d49db0-cb2c-11ea-96be-d1d226963d5e

@liyasthomas
Copy link
Member

snyk retry

@liyasthomas liyasthomas merged commit 42e283f into hoppscotch:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants