Collections

[TheHollidayInn]

Hey! I wanted to get this posted to get some feedback and show progress

Closes #29

• Collections
  • Create
  • Read
  • Update
  • Delete
  • Export
• Folders
  • Create
  • Read
  • Update
  • Delete
• Requests
  • Read
  • Update
  • Delete
  • Save Current
• Other
  • Maybe add as a side panel
  • Style updates

[ghost]

DeepCode Report (#ee5807)

DeepCode analyzed this pull request.
There are no new issues.

[TravisBuddy]

Hey @TheHollidayInn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d2406490-e49b-11e9-98d3-55f5e12e8fe5

[liyasthomas]

So far, so good. I liked your approach on storing collections.

[yubathom]

Just mounted locally. Nice approach with vuex @TheHollidayInn!

I have two doubts:

1. How would you like to deal the shareability of theese collections? Are you considering an backend api to give you a response so you could populate the store before the creation of the view?

obs. Don't keep multiple requests data in urls due to its characters limit

2. Would you consider using the data of history of local storage (localStorage.history) to easily populate/update the store of theese collections? Or maybe keeping them synced?

[TheHollidayInn]

Hey @yubathom! For this I figured I would not implement a backend, but implement locally (save with local storage). It wouldn't be much to add a backend later or event add an option for users to supply their own.

For sharing, I was thinking of just exporting the JSON like postman does and allow for users to also import JSON.

[liyasthomas]

Thought I should just ping @TheHollidayInn to know the status of this PR.

[TravisBuddy]

Hey @TheHollidayInn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 16206f20-f013-11e9-983c-41f05746e0df

[TheHollidayInn]

Hey! Sorry, got a little behind, but I will push my updates tomorrow.

[TravisBuddy]

Hey @TheHollidayInn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dbe5fbc0-f0ff-11e9-aa1b-53c400f64b87

[TheHollidayInn]

Alright! I think I have the first round of features (Although there are plenty more I could think of). I'd appreciate any feedback. Sorry it took me so long.

[TravisBuddy]

Hey @TheHollidayInn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 63ab0f90-f48a-11e9-9e2b-01a46d152451

[liyasthomas]

LGTM

[TravisBuddy]

Hey @TheHollidayInn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e3f1d5e0-f4ac-11e9-9e2b-01a46d152451

[liyasthomas]

@TheHollidayInn This is awesome! I've added few stylings.

After some manual testing, I often ran into some errors.

• editCollection often brings up addCollection modal. Especially on first click. From second or third click onwards, modal seems to be correct.
• This same issue happens to editRequest and editFolder oftentimes. But nit always. Any idea what's wrong?

I tried to debug but logic seems to be fine. Even though you use same modal to create and edit, logic seems to be correct. Any idea what went wrong let me know if you could reproduce the bug!