-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic e2e tests #181
Add basic e2e tests #181
Conversation
DeepCode Report (#ade773)DeepCode analyzed this pull request. |
Hey @yubathom, TravisBuddy Request Identifier: bf9ad560-e648-11e9-9927-991e8c29daea |
This is AWESOME ✨ We'll write more tests 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗👌
Hey @liyasthomas, thank you for reviewing and merging. And sorry co's I've got sick and was out theese days. I tested the deepcodecheck changes and that broke the tests. I think is because I am not able to catch in cypress promises. I will check at cypress docs and look for workarounds to keep the tests code cleaner in future tests. |
Add basic e2e tests with cypress
Related to #65.
preview of
npm run dev:e2e
this should be running in ci too - https://travis-ci.org/yubathom/postwoman/builds/593324131
at
before_scripts
wich should give some reports at every pull requests
New scripts:
npm run tests
- run tests once in cli mode. Now just these e2e. In future we should run unit tests too.npm run dev:e2e
- will start localhos:3000 and run e2e tests within cypress app browser. This is the default mode to tdd.Notes:
run dev
) mounted at the travis-ci.tests/e2e/fixtures/
andtests/e2e/support/commands.js
). We should create some fixtures of firebase. Something like this.