Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated threshold and rootMargin for IntersectionObserver #182

Merged
merged 1 commit into from
Oct 4, 2019
Merged

updated threshold and rootMargin for IntersectionObserver #182

merged 1 commit into from
Oct 4, 2019

Conversation

edisonaugusthy
Copy link
Contributor

added updated threshold and rootMargin for IntersectionObserver to avoid the flickering issue in mobile devices
will fix #157

added updated threshold and rootMargin for IntersectionObserver to avoid the flickering issue in mobile devices
@ghost
Copy link

ghost commented Oct 4, 2019

DeepCode Report (#12317d)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas liyasthomas self-requested a review October 4, 2019 04:43
@TravisBuddy
Copy link

Hey @edisonaugusthy,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c3163720-e661-11e9-9927-991e8c29daea

@liyasthomas liyasthomas added the bug fix This fixes a bug label Oct 4, 2019
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 👌

@liyasthomas liyasthomas merged commit 3d116de into hoppscotch:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Again Button Constantly Flickering
3 participants