-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CORS and mixed content issue #199
Conversation
Because - Get over of CORS and mixed content browser errors
DeepCode Report (#395029)DeepCode analyzed this pull request. |
Hey @hosseinnedaee, TravisBuddy Request Identifier: 48432ae0-f2b3-11e9-8575-bb3eea981d29 |
icon: 'error' | ||
}); | ||
if(!this.$store.state.postwoman.settings.PROXY_ENABLED) { | ||
this.$toast.info('Turn on the proxy', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, my only recommendation is that this be renamed to 'Try enabling the proxy' or words to that effect, but it's not that significant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Switch to Proxy mode"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - but perhaps with the question mark. The idea being to imply to the user that it's something that might help with the error.
Oh- just one other issue, we need to add |
See #200 which includes these commits with some finishing touches and bug fixes. |
In this PR I used Nuxtjs serverMiddleware to create a proxy server and pass the requests through the proxy and get over CORS and mixed-content issue's
resolving #175 and #2