Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy URL #201

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Fix proxy URL #201

merged 1 commit into from
Oct 20, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Oct 20, 2019

No description provided.

@NBTX NBTX merged commit 5e551b4 into hoppscotch:master Oct 20, 2019
@ghost
Copy link

ghost commented Oct 20, 2019

DeepCode Report (#f6316c)

DeepCode analyzed this pull request.
There are no new issues.

@NBTX
Copy link
Contributor Author

NBTX commented Oct 20, 2019

Merging immediately because this broke production.

@TravisBuddy
Copy link

Hey @NBTX,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 683b8660-f2d8-11e9-a94e-c51b88d78b8d

@NBTX
Copy link
Contributor Author

NBTX commented Oct 20, 2019

...or not?
@liyasthomas can you run a manual build from Travis?

@liyasthomas
Copy link
Member

Im running

@liyasthomas
Copy link
Member

liyasthomas commented Oct 20, 2019

@NBTX
Copy link
Contributor Author

NBTX commented Oct 20, 2019

Ah yeah I figured out what was going on. The link sent me to travis-ci.org which for some reason is completely seperate to travis-ci.com and didn't even recognize that my account existed.

@liyasthomas
Copy link
Member

Btw, you can't hot merge PRs without CI finishing tests and builds. New commit (even a merge) trigger concurrent build. This caused build error. On travis-ci.com (not .org) build was already triggered.

I wonder why this damn Travis CI bot haven't migrated to .com yet 🤐

@NBTX
Copy link
Contributor Author

NBTX commented Oct 20, 2019

Yeah or at the very least they should check if you're logged in on one and not the other and redirect you 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants