Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work in Progress: feature/allow-collections-importing #209

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Work in Progress: feature/allow-collections-importing #209

merged 4 commits into from
Oct 24, 2019

Conversation

vlad0337187
Copy link
Contributor

@vlad0337187 vlad0337187 commented Oct 23, 2019 •
edited
Loading

Commits:

  • feature: allow importing collections from local JSON files
  • refactor: split 'components/collections/addCollection.vue' to 'addCollection', 'editCollection'
  • refactor: split 'components/collections/addFolder.vue' to 'addFolder', 'editFolder'
  • refactor, fix: split 'components/collections/saveRequest.vue' to 'editRequest', 'saveRequestAs'; fix saving bugs

@ghost
Copy link

ghost commented Oct 23, 2019 •
edited by ghost
Loading

DeepCode Report (#bd64e4)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @vlad0337187,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7e9a4ed0-f5d2-11e9-a1fe-396a3052531f

@liyasthomas liyasthomas self-requested a review October 23, 2019 20:20
@liyasthomas liyasthomas added feature New feature or request need testing Needs to be tested before merging onto production labels Oct 23, 2019
@vlad0337187 vlad0337187 changed the title feature: allow importing collections from local JSON files Work in Progress: feature/allow-collections-importing Oct 23, 2019
@TravisBuddy
Copy link

Hey @vlad0337187,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: db6750b0-f5f3-11e9-a1fe-396a3052531f

@TravisBuddy
Copy link

Hey @vlad0337187,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c581f000-f604-11e9-8561-177d15c65e0c

@vlad0337187 vlad0337187 force-pushed the feature/allow-collections-importing branch from 167adc8 to 3743ff9 Compare October 24, 2019 02:21
@TravisBuddy
Copy link

Hey @vlad0337187,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7e7e5a30-f605-11e9-8561-177d15c65e0c

@liyasthomas liyasthomas added the wip Work in progress label Oct 24, 2019
@liyasthomas
Copy link
Member

liyasthomas commented Oct 24, 2019 •
edited
Loading

@vlad0337187 ping me when MVP is ready.

@vlad0337187
Copy link
Contributor Author

@liyasthomas , could you, please test saving requests, and review code ?

Made some components splitting, removed need in storing indexes.
Probably, sometimes it's too much code, sometimes - I cleaned up unnecessary.

As I think, I fixed issues in general, replaced difficult to fix parts with more explicit and straightforward.

Will answer any questions in Telegram.

Thanks.

@TravisBuddy
Copy link

Hey @vlad0337187,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 28df9700-f64c-11e9-9890-1bf57bc9f734

@liyasthomas
Copy link
Member

Yeah sure.

liyasthomas
liyasthomas approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Didn't had any issues with connections.

@liyasthomas liyasthomas merged commit 2f47fc5 into hoppscotch:master Oct 24, 2019
This was referenced Oct 24, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

@NBTX NBTX Awaiting requested review from NBTX

@AndrewBastin AndrewBastin Awaiting requested review from AndrewBastin

Assignees
No one assigned
Labels
feature New feature or request need testing Needs to be tested before merging onto production wip Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad0337187 @TravisBuddy @liyasthomas