-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: keeping information on page change #211
Conversation
DeepCode Report (#6c28eb)DeepCode analyzed this pull request. |
@breno-pereira there is a little merge conflict. Please rebase and pull or solve conflict manually. |
Hey @breno-pereira, TravisBuddy Request Identifier: 5d03e5f0-f6b9-11e9-adce-d133a4a19a4f |
CI tests passed 🙌🏼 |
@breno-pereira The only bug I found is: on Now (postwoman.io):
|
I again went through the code and now I doubt encoding payload as query parameters were already there 😕 |
Hey @breno-pereira, TravisBuddy Request Identifier: 3c64a420-f7e9-11e9-b720-730f6f1bb67a |
@liyasthomas |
Hey @breno-pereira, TravisBuddy Request Identifier: 5d4fb1f0-f7eb-11e9-b720-730f6f1bb67a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Work done to address issue #203
( Closes #203 )
Changes
VuexPersist
to save the state inlocalStorage
index.vue