Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: keeping information on page change #211

Merged
merged 4 commits into from
Oct 26, 2019

Conversation

breno-pereira
Copy link
Contributor

@breno-pereira breno-pereira commented Oct 24, 2019

Work done to address issue #203
( Closes #203 )

Changes

  • Create state file
  • Create mutation file
  • Use VuexPersist to save the state in localStorage
  • Remove local data from index.vue

@ghost
Copy link

ghost commented Oct 24, 2019

DeepCode Report (#6c28eb)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas
Copy link
Member

liyasthomas commented Oct 24, 2019

@breno-pereira there is a little merge conflict. Please rebase and pull or solve conflict manually.

@liyasthomas liyasthomas self-requested a review October 24, 2019 23:46
@liyasthomas liyasthomas added feature New feature or request need testing Needs to be tested before merging onto production labels Oct 24, 2019
@TravisBuddy
Copy link

Hey @breno-pereira,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5d03e5f0-f6b9-11e9-adce-d133a4a19a4f

@liyasthomas
Copy link
Member

CI tests passed 🙌🏼
Will run some manual tests and then merge!

@liyasthomas
Copy link
Member

liyasthomas commented Oct 25, 2019

@breno-pereira
Using VuexPersist for preserving state seems to be working fine 🎉

The only bug I found is: on POST, PUT & PATCH requests, the payload is not being send. I went through the code and found payload is being sent as string instead JSON


Now (postwoman.io): bodyParams & rawRequestBody being sent as JSON

Screen Shot 2019-10-25 at 8 17 57 AM
Screen Shot 2019-10-25 at 8 26 30 AM


After (#211): bodyParams & rawRequestBody being sent as string

Screen Shot 2019-10-25 at 8 18 20 AM
Screen Shot 2019-10-25 at 8 27 03 AM


I think you must've confused bodyParams & rawRequestBody with queryString & params.

  • bodyParams & rawRequestBody = payload of format {"key":"value"} and type JSON. Its not working, and is being encoded as key=value&key=value 🐛

  • queryString and params = url prameters of format ?key=value and type string. Working fine 👍

@liyasthomas
Copy link
Member

I again went through the code and now I doubt encoding payload as query parameters were already there 😕

@TravisBuddy
Copy link

Hey @breno-pereira,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3c64a420-f7e9-11e9-b720-730f6f1bb67a

@breno-pereira
Copy link
Contributor Author

@liyasthomas
Now I think it's correct

@TravisBuddy
Copy link

Hey @breno-pereira,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5d4fb1f0-f7eb-11e9-b720-730f6f1bb67a

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyasthomas liyasthomas requested a review from NBTX October 26, 2019 12:41
@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Oct 26, 2019
@liyasthomas liyasthomas merged commit 0647fc3 into hoppscotch:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request need testing Needs to be tested before merging onto production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All changes in input fields lost when you switch to another page
3 participants