Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed frame colors toggle #216

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

mateusppereira
Copy link
Contributor

@mateusppereira mateusppereira commented Oct 25, 2019

There is was a bug on frame colors toggle. When you click once the toggle changes.

  • Change the setting name to FRAME_COLORS_ENABLED to match the pattern and improve readability
  • Using toggleSetting method for toggle components

To reproduce this bug, just open https://postwoman.io/settings and try to toggle Multi-Color in Frames section

fixed: https://www.loom.com/share/bd598afe32b44cb583fed608ccb50584

@ghost
Copy link

ghost commented Oct 25, 2019

DeepCode Report (#9103ce)

DeepCode analyzed this pull request.
There are no new issues.

@mateusppereira mateusppereira changed the title Fixed frame colors toggle [WIP] Fixed frame colors toggle Oct 25, 2019
@TravisBuddy
Copy link

Hey @mateusppereira,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2298b780-f757-11e9-bba2-bfeb3afa92fa

@mateusppereira mateusppereira changed the title [WIP] Fixed frame colors toggle Fixed frame colors toggle Oct 25, 2019
@NBTX NBTX merged commit 84eda99 into hoppscotch:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants