Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #227 Exclude credentials from permalink #228

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

reefqi037
Copy link
Contributor

Tried to fix #227. Maybe there is better way but this is what I can come out off.

@ghost
Copy link

ghost commented Oct 29, 2019

DeepCode Report (#282749)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas liyasthomas requested a review from NBTX October 29, 2019 13:46
liyasthomas
liyasthomas approved these changes Oct 29, 2019
@TravisBuddy
Copy link

Hey @reefqi037,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: ebf36550-fa52-11e9-97f1-ff8640b58534

@liyasthomas liyasthomas self-requested a review October 29, 2019 14:10
@NBTX NBTX merged commit 8c98e7f into hoppscotch:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credentials are still being included in Permalink even when "Include in URL" is turned off
4 participants