Feature/pre request script #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#ad1c74)DeepCode analyzed this pull request. |
|
Hey @nickpalenchar, TravisBuddy Request Identifier: 44aad4c0-fabd-11e9-94bd-fbbf6873bcfd |
liyasthomas
added
core
|
Works good!
|
|
Agreed on the post-merge todos! Additionally, we could also indicate this feature is not fully stable as-is. Something as simple as changing the header to |
|
Hey @nickpalenchar, TravisBuddy Request Identifier: 2c05fc60-fac2-11e9-94bd-fbbf6873bcfd |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #218
scrapped the old branch
feature/dynamic-headersafter merge woes (will delete soon).Lots more to think about, but I feel it satisfies mvp (and would love to get this in master so I can take a break from keeping it up-to-date manually 😅)
Request section has a
codebutton. When clicked, it enables pre-request scripts. A pre-request script section appears above where javascript can be entered.pre-request script has access to a postwoman api object (
pw) that can be interacted with. Right now the only thing to do ispw.environment.set("key", "value")to set a variable that can be used in areas of the request. Note this is native javascript, so any js method can be used. Final values are all treated as strings.Test by setting something in the pre-request script
pw.environment.set("route", "/api/users");and replacing parts of the request within double angle brackets (path =<<route>>). Response should function the same as if the final value was statically typed.Additionally, requests made this way end up in history with the same
codeicon. Hovering over it informs the user that this entry in the history used pre-request scripts. Due to it's highly dynamic potential, you could say that note serves as a warning!tangentially -- @NBTX can you make the request-chaining into its own issue? I realized it's quite separate from this one so it would be good to address that after this.