Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic i18n support #351

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Basic i18n support #351

merged 4 commits into from
Nov 27, 2019

Conversation

liyasthomas
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Nov 27, 2019 •
edited by ghost
Loading

DeepCode Report (#a74522)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas liyasthomas mentioned this pull request Nov 27, 2019
Closed
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b384afe0-10f9-11ea-b8ff-d5ab8a371226

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 655fdba0-10fe-11ea-b8ff-d5ab8a371226

@liyasthomas
Copy link
Member Author

Retry DeepCode

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 87f69310-10ff-11ea-b8ff-d5ab8a371226

@liyasthomas liyasthomas self-assigned this Nov 27, 2019
@liyasthomas
Copy link
Member Author

@NBTX please review this.

@liyasthomas liyasthomas added core Changes regarding core concepts feature New feature or request labels Nov 27, 2019
@liyasthomas liyasthomas added this to the v2.0 milestone Nov 27, 2019
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: db1f0900-110e-11ea-b8ff-d5ab8a371226

@liyasthomas liyasthomas merged commit 623b177 into master Nov 27, 2019
@liyasthomas liyasthomas deleted the i18n branch November 27, 2019 12:10
@liyasthomas liyasthomas restored the i18n branch November 27, 2019 12:10
@liyasthomas liyasthomas mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBTX NBTX Awaiting requested review from NBTX

Assignees

@liyasthomas liyasthomas

Labels
core Changes regarding core concepts feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liyasthomas @TravisBuddy