Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n #366

Merged
merged 15 commits into from
Nov 28, 2019
Merged

I18n #366

merged 15 commits into from
Nov 28, 2019

Conversation

liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Nov 28, 2019 •
edited
Loading

fixes #336

@ghost
Copy link

ghost commented Nov 28, 2019 •
edited by ghost
Loading

DeepCode Report (#fe383d)

DeepCode analyzed this pull request.
There is 1 new info report.

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2d2a22d0-11f4-11ea-b428-cb0bccf60dd8

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9b98ad10-11f7-11ea-b428-cb0bccf60dd8

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3102f260-1203-11ea-b428-cb0bccf60dd8

@liyasthomas
Merge pull request #369 from wahwahid/i18n
fe14286 
Update i18n keywords for Bahasa Indonesia
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 5b3153f0-1204-11ea-b428-cb0bccf60dd8

NBTX
NBTX reviewed Nov 28, 2019
View reviewed changes
lang/fa-IR.js Show resolved Hide resolved
NBTX
NBTX reviewed Nov 28, 2019
View reviewed changes
lang/pt-BR.js Show resolved Hide resolved
NBTX
NBTX previously approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@NBTX NBTX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is fine, I haven't checked any of the translations except English and French.

@liyasthomas liyasthomas self-assigned this Nov 28, 2019
@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f9cb0c80-1232-11ea-b428-cb0bccf60dd8

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: caecfe30-1234-11ea-b428-cb0bccf60dd8

@liyasthomas liyasthomas merged commit 6959a45 into master Nov 28, 2019
@liyasthomas liyasthomas deleted the i18n branch November 28, 2019 23:15
@liyasthomas liyasthomas restored the i18n branch November 28, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment