Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twitter summary card image url #378

Merged
merged 1 commit into from
Nov 30, 2019
Merged

fix: twitter summary card image url #378

merged 1 commit into from
Nov 30, 2019

Conversation

peterpeterparker
Copy link
Contributor

@peterpeterparker peterpeterparker commented Nov 30, 2019

According my todays tweet (https://twitter.com/daviddalbusco/status/1200671798708391937?s=20) it seems that the image provided in the meta tag twitter:image respectively ./logo.jpg wasn't interpreted by Twitter.

For DeckDeckGo I use absolute URL and I double checked DEV.to, which also use absolute.

Therefore I think that the image might need to be provide in such form respectively https://postwoman.io/logo.jpg

P.S.: I didn't modified the og:image because I quickly tested Facebook and it seems they are fine with a relative path

@ghost
Copy link

ghost commented Nov 30, 2019

DeepCode Report (#a42136)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @peterpeterparker,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dd324fe0-1343-11ea-9fec-2bc1e44a98db

@liyasthomas
Copy link
Member

liyasthomas commented Nov 30, 2019

Are you sure..? Twitter might've cached old summary image.

@liyasthomas
Copy link
Member

Screenshot_20191130-130642
Screenshot_20191130-130628

@peterpeterparker
Copy link
Contributor Author

peterpeterparker commented Nov 30, 2019

@liyasthomas GitHub card is fine, https://postwomam.io isn't

Tried to refresh the Twitter card with their validator https://cards-dev.twitter.com/validator, same outcome, no image.

update or maybe another image tag is missing too?

@peterpeterparker
Copy link
Contributor Author

Capture d’écran 2019-11-30 à 08 39 15

@liyasthomas liyasthomas merged commit 772fdd5 into hoppscotch:master Nov 30, 2019
@peterpeterparker
Copy link
Contributor Author

@liyasthomas @TravisBuddy ping me when deployed, I'll be happy to try out again and if necessary send another PR

@peterpeterparker peterpeterparker deleted the twitter-card-img branch November 30, 2019 07:41
@liyasthomas
Copy link
Member

Just verify later today and ping back. ♥️

@peterpeterparker
Copy link
Contributor Author

@liyasthomas

looks like it was deployed so if I had a dummy param to the url, the social card do display the images, otherwise, it still doesn't display it...maybe takes a while until Twitter refresh its cache...

Capture d’écran 2019-11-30 à 16 41 32

Capture d’écran 2019-11-30 à 16 41 46

@liyasthomas
Copy link
Member

Yeah. Acknowledged. Thanks for the quick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants