-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: twitter summary card image url #378
fix: twitter summary card image url #378
Conversation
DeepCode Report (#a42136)DeepCode analyzed this pull request. |
Hey @peterpeterparker, TravisBuddy Request Identifier: dd324fe0-1343-11ea-9fec-2bc1e44a98db |
Are you sure..? Twitter might've cached old summary image. |
@liyasthomas GitHub card is fine, https://postwomam.io isn't Tried to refresh the Twitter card with their validator https://cards-dev.twitter.com/validator, same outcome, no image. update or maybe another image tag is missing too? |
@liyasthomas @TravisBuddy ping me when deployed, I'll be happy to try out again and if necessary send another PR |
Just verify later today and ping back. |
looks like it was deployed so if I had a dummy param to the url, the social card do display the images, otherwise, it still doesn't display it...maybe takes a while until Twitter refresh its cache... |
Yeah. Acknowledged. Thanks for the quick PR. |
According my todays tweet (https://twitter.com/daviddalbusco/status/1200671798708391937?s=20) it seems that the image provided in the meta tag
twitter:image
respectively./logo.jpg
wasn't interpreted by Twitter.For DeckDeckGo I use absolute URL and I double checked DEV.to, which also use absolute.
Therefore I think that the image might need to be provide in such form respectively
https://postwoman.io/logo.jpg
P.S.: I didn't modified the
og:image
because I quickly tested Facebook and it seems they are fine with a relative path