Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom methods support #400

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Custom methods support #400

merged 4 commits into from
Dec 4, 2019

Conversation

liyasthomas
Copy link
Member

fixes #398

@liyasthomas liyasthomas requested a review from NBTX December 4, 2019 14:50
@liyasthomas liyasthomas self-assigned this Dec 4, 2019
@ghost
Copy link

ghost commented Dec 4, 2019

DeepCode Report (#7d5a84)

DeepCode analyzed this pull request.
There are no new issues.

@ghost
Copy link

ghost commented Dec 4, 2019 •
edited by ghost
Loading

DeepCode Report (#5fbf48)

DeepCode analyzed this pull request.
There are no new issues.

@liyasthomas liyasthomas added the feature New feature or request label Dec 4, 2019
@liyasthomas
Copy link
Member Author

Retry DeepCode

@TravisBuddy
Copy link

Hey @liyasthomas,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2afa2440-16a6-11ea-93d3-257117e2c129

@liyasthomas liyasthomas added the need testing Needs to be tested before merging onto production label Dec 4, 2019
@TravisBuddy
Copy link

Hey @liyasthomas,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1a627b80-16a8-11ea-93d3-257117e2c129

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 22f5df30-16b2-11ea-93d3-257117e2c129

@liyasthomas liyasthomas merged commit d687c9f into master Dec 4, 2019
@liyasthomas liyasthomas deleted the methods branch December 4, 2019 16:22
This was referenced Dec 23, 2020
Open
Open
This was referenced Sep 5, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Mar 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NBTX NBTX Awaiting requested review from NBTX

Assignees

@liyasthomas liyasthomas

Labels
feature New feature or request need testing Needs to be tested before merging onto production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom request method
2 participants
@liyasthomas @TravisBuddy