Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: stick to Vue.js best practices #432

Merged
merged 16 commits into from
Dec 15, 2019
Merged

chore: stick to Vue.js best practices #432

merged 16 commits into from
Dec 15, 2019

Conversation

jamesgeorge007
Copy link
Member

  • Self closing components.
  • Use directive short-hands across the code-base for consistency.

@jamesgeorge007
refactor: make component tag self closing
4c82ef8
@jamesgeorge007
refactor: make history component self closing
fcc6f5a
@jamesgeorge007
refactor: use property shorthand for consistency
82096f3
@jamesgeorge007
refactor: make collection component self closing
b20cb04
@jamesgeorge007
refactor: use property shorthand for consistency
f49bfb4
@jamesgeorge007
refactor: make request component self closing
998a925
@jamesgeorge007
refactor: use property shorthand for consistency
9223044
@jamesgeorge007
refactor: use property shorthand for consistency
0791d19
@jamesgeorge007
refactor: use property shorthand for consistency
928ace5
@jamesgeorge007
refactor: make use of v-bind directive shorthand
48bd772 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
24ee395 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
c50cbc9 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
d2086b1 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
7b0a1c4 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
5762cea 
vue.js best practices
@jamesgeorge007
refactor: make use of v-bind directive shorthand
ffe4796 
vue.js best practices
@ghost
Copy link

ghost commented Dec 15, 2019

DeepCode Report (#ffe479)

DeepCode analyzed this pull request.
There are no new issues.

@jamesgeorge007 jamesgeorge007 self-assigned this Dec 15, 2019
@jamesgeorge007 jamesgeorge007 added feature New feature or request refactor Code refactoring labels Dec 15, 2019
@jamesgeorge007 jamesgeorge007 added this to the v2.0 milestone Dec 15, 2019
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0e94ee60-1f44-11ea-ba47-7f442aed9c1e

@liyasthomas liyasthomas merged commit 29c6109 into master Dec 15, 2019
@jamesgeorge007 jamesgeorge007 deleted the refactor/enhancements branch December 15, 2019 16:45
This was referenced Dec 23, 2020
Open
Open
This was referenced Sep 5, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees

@jamesgeorge007 jamesgeorge007

Labels
feature New feature or request refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @TravisBuddy @liyasthomas