Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(oauth): Added method signatures as per JSDoc conventions #486

Merged
merged 21 commits into from
Jan 11, 2020
Merged

chore(oauth): Added method signatures as per JSDoc conventions #486

merged 21 commits into from
Jan 11, 2020

Conversation

jamesgeorge007
Copy link
Member

Follow up of #485 #476

@ghost
Copy link

ghost commented Jan 11, 2020 •
edited by ghost
Loading

DeepCode's analysis on #5fffc5 found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 1 issue were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@jamesgeorge007 jamesgeorge007 added core Changes regarding core concepts documentation Improvements or additions to documentation feature New feature or request labels Jan 11, 2020
@jamesgeorge007 jamesgeorge007 added this to the v2.0 milestone Jan 11, 2020
@jamesgeorge007 jamesgeorge007 self-assigned this Jan 11, 2020
jamesgeorge007
jamesgeorge007 commented Jan 11, 2020
View reviewed changes
assets/js/oauth.js Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 4fe84db0-344a-11ea-b5a3-65565334105f

liyasthomas
liyasthomas reviewed Jan 11, 2020
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best documented piece of code I've seen in this project.

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 644b8920-3463-11ea-83d9-8392e2feaaba

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0c1d9260-3464-11ea-83d9-8392e2feaaba

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 29fcf8c0-3464-11ea-83d9-8392e2feaaba

@jamesgeorge007 jamesgeorge007 changed the title chore: Added method signatures as per JSDoc conventions chore(oauth): Added method signatures as per JSDoc conventions Jan 11, 2020
@liyasthomas liyasthomas added do not merge This will break everything and removed do not merge This will break everything labels Jan 11, 2020
@jamesgeorge007 jamesgeorge007 merged commit 119eb32 into master Jan 11, 2020
@jamesgeorge007 jamesgeorge007 deleted the refactor branch January 11, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees

@jamesgeorge007 jamesgeorge007

Labels
core Changes regarding core concepts documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @TravisBuddy @liyasthomas