Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #491 from liyasthomas/i18n #491

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Merge pull request #491 from liyasthomas/i18n #491

merged 2 commits into from
Jan 14, 2020

Conversation

liyasthomas
Copy link
Member

No description provided.

Alec Ananian and others added 2 commits January 14, 2020 07:43
Added en locale as localization fallback
Replaced hard-coded strings with localizable strings
@ghost
Copy link

ghost commented Jan 14, 2020

DeepCode's analysis on #36c984 found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @liyasthomas,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e9f56a80-36ef-11ea-a8cf-c90382c1967d

@liyasthomas liyasthomas changed the title i18n Merge pull request #491 from liyasthomas/i18n Jan 14, 2020
@liyasthomas liyasthomas merged commit e7a15c9 into master Jan 14, 2020
@liyasthomas liyasthomas deleted the i18n branch January 14, 2020 17:05
@liyasthomas liyasthomas restored the i18n branch January 14, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants