Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error marking in GraphQL query editor #505

Merged
merged 7 commits into from
Jan 18, 2020

Conversation

AndrewBastin
Copy link
Member

@AndrewBastin AndrewBastin commented Jan 18, 2020

This PR intends to add the ability to annotate GraphQL syntax errors made in the query.

#468

@ghost
Copy link

ghost commented Jan 18, 2020

DeepCode's analysis on #efe21d found:

  • 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@AndrewBastin AndrewBastin added the feature New feature or request label Jan 18, 2020
@AndrewBastin AndrewBastin added this to the v2.0 milestone Jan 18, 2020
@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 182fbe50-39d9-11ea-9120-1db9a1cd0038

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 54ecc130-39d9-11ea-9120-1db9a1cd0038

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6ba701a0-3a16-11ea-9120-1db9a1cd0038

@AndrewBastin AndrewBastin merged commit d9feffa into hoppscotch:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants