Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/post request tests #518

Merged
merged 20 commits into from
Jan 27, 2020
Merged

Feature/post request tests #518

merged 20 commits into from
Jan 27, 2020

Conversation

aeeed99
Copy link
Contributor

@aeeed99 aeeed99 commented Jan 24, 2020

Closes #465

Want to get this in while it's still in sync with master. Minimal but functional and ready to be used 😄

The tests button is next to the pre-request script button, which opens a window to code tests. A commented out line given an example of a (failing) test. Comment it in to test the test. Other examples are documented here, and can all be tried.

Biggest todo still is saving to history. Will do later this weekend.

The UI is minimal and... a little funky.. could def use some formatting help by someone better at styling than I am!

In terms of functionality+docs I'll add a bit more incrementally once merged. This was a really fun one!
If someone else merges I recommend squashing and merging.. I made a lot of incremental commits.

@ghost
Copy link

ghost commented Jan 24, 2020

DeepCode's analysis on #dc236c found:

  • 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2020

This pull request introduces 3 alerts when merging 113939c into 92d8878 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@TravisBuddy
Copy link

Hey @nickpalenchar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ae300ed0-3ed6-11ea-8d14-875df00ea6f6

@TravisBuddy
Copy link

Hey @nickpalenchar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 13d457d0-3ed9-11ea-8d14-875df00ea6f6

@TravisBuddy
Copy link

Hey @nickpalenchar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 08728cb0-3ee1-11ea-8d14-875df00ea6f6

@liyasthomas
Copy link
Member

Failing build seems to be an issue with Travis CI. Will report back after a retry.

@liyasthomas liyasthomas added the wip Work in progress label Jan 25, 2020
@liyasthomas liyasthomas self-requested a review January 25, 2020 05:11
@TravisBuddy
Copy link

Hey @nickpalenchar,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a0074520-3f86-11ea-9031-6faafd84f961

@liyasthomas
Copy link
Member

Let me investigate whats wrong.

@aeeed99
Copy link
Contributor Author

aeeed99 commented Jan 25, 2020

thanks

@liyasthomas
Copy link
Member

There's no problem with our code, while running tests locally everything seem to be working fine. The issue is with Travis CI.

Netlify successfully built the project for deploy preview. Will wait until CI team fixes this issue from their side. Meanwhile I'll optimize the UI a bit.

@AndrewBastin
Copy link
Member

Actually @nickpalenchar, there is a build issue with your code, I will commit fixes for them in a second.

@TravisBuddy
Copy link

Hey @nickpalenchar,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a1ff6130-406e-11ea-bff6-b53ae007d2db

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyasthomas liyasthomas merged commit aefe0ab into master Jan 27, 2020
@liyasthomas liyasthomas deleted the feature/post-request-tests branch January 27, 2020 00:14
@liyasthomas liyasthomas restored the feature/post-request-tests branch January 27, 2020 00:14
@aeeed99
Copy link
Contributor Author

aeeed99 commented Jan 27, 2020

@AndrewBastin thanks so much for your help!

@jamesgeorge007 jamesgeorge007 mentioned this pull request Jan 27, 2020
@liyasthomas liyasthomas added core Changes regarding core concepts and removed wip Work in progress labels Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes regarding core concepts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] - Tests tab
4 participants