-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/post request tests #518
Conversation
DeepCode's analysis on #dc236c found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
This pull request introduces 3 alerts when merging 113939c into 92d8878 - view on LGTM.com new alerts:
|
Hey @nickpalenchar, TravisCI finished with status TravisBuddy Request Identifier: ae300ed0-3ed6-11ea-8d14-875df00ea6f6 |
Hey @nickpalenchar, TravisCI finished with status TravisBuddy Request Identifier: 13d457d0-3ed9-11ea-8d14-875df00ea6f6 |
Hey @nickpalenchar, TravisCI finished with status TravisBuddy Request Identifier: 08728cb0-3ee1-11ea-8d14-875df00ea6f6 |
Failing build seems to be an issue with Travis CI. Will report back after a retry. |
Hey @nickpalenchar, TravisCI finished with status TravisBuddy Request Identifier: a0074520-3f86-11ea-9031-6faafd84f961 |
Let me investigate whats wrong. |
thanks |
There's no problem with our code, while running tests locally everything seem to be working fine. The issue is with Travis CI. Netlify successfully built the project for deploy preview. Will wait until CI team fixes this issue from their side. Meanwhile I'll optimize the UI a bit. |
Actually @nickpalenchar, there is a build issue with your code, I will commit fixes for them in a second. |
Hey @nickpalenchar, TravisBuddy Request Identifier: a1ff6130-406e-11ea-bff6-b53ae007d2db |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AndrewBastin thanks so much for your help! |
Closes #465
Want to get this in while it's still in sync with master. Minimal but functional and ready to be used 😄
The tests button is next to the pre-request script button, which opens a window to code tests. A commented out line given an example of a (failing) test. Comment it in to test the test. Other examples are documented here, and can all be tried.
Biggest todo still is saving to history. Will do later this weekend.
The UI is minimal and... a little funky.. could def use some formatting help by someone better at styling than I am!
In terms of functionality+docs I'll add a bit more incrementally once merged. This was a really fun one!
If someone else merges I recommend squashing and merging.. I made a lot of incremental commits.